[jira] [Commented] (STORM-563) Kafka Spout doesn't pick up from the beginning of the queue unless forceFromStart specified

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/STORM-563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14218967#comment-14218967
 ] 

ASF GitHub Bot commented on STORM-563:
--------------------------------------

Github user nathanmarz commented on the pull request:

    https://github.com/apache/storm/pull/321#issuecomment-63757949
  
    That doesn't look right. That change makes the if statement there 
meaningless. That method should just be removed, and the other getOffset method 
should be changed to:
    
    ```
    public static long getOffset(SimpleConsumer consumer, String topic, int 
partition, Long startOffsetTime) {
       if(startOffsetTime==null) startOffsetTime = 
kafka.api.OffsetRequest.LatestTime();
       // the rest the same
    ```


> Kafka Spout doesn't pick up from the beginning of the queue unless 
> forceFromStart specified
> -------------------------------------------------------------------------------------------
>
>                 Key: STORM-563
>                 URL: https://issues.apache.org/jira/browse/STORM-563
>             Project: Apache Storm
>          Issue Type: Bug
>            Reporter: Sriharsha Chintalapani
>            Assignee: Sriharsha Chintalapani
>
> KafkaUtil.getOffset starts from LatestTime unless forceFromStart specified. 
> It should pick this from KafkaConfig.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)