Github user nathanmarz commented on the pull request:

    https://github.com/apache/storm/pull/321#issuecomment-63757949
  
    That doesn't look right. That change makes the if statement there 
meaningless. That method should just be removed, and the other getOffset method 
should be changed to:
    
    ```
    public static long getOffset(SimpleConsumer consumer, String topic, int 
partition, Long startOffsetTime) {
       if(startOffsetTime==null) startOffsetTime = 
kafka.api.OffsetRequest.LatestTime();
       // the rest the same
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to