Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/319#issuecomment-64962354
  
    @lightyang 
    Was this causing test failures, or was this just trying to clear up some 
confusion.
    
    Either way, because this is a code change it would be nice to have a JIRA 
to track it.  If you could file one at http://issues.apache.org/jira under the 
STORM project that would be great.
    
    Also it looks like you missed a couple of places
    
    
https://github.com/lightyang/incubator-storm/blob/fix-test/storm-core/test/clj/backtype/storm/supervisor_test.clj#L144-147
    
    As for the change itself, I am a +1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to