Github user taojoe commented on the pull request:
https://github.com/apache/storm/pull/285#issuecomment-65891279
hi Robert,
thanks very much, this is the first time for me. I change
supervisor_test.clj the same way. but I don't the the apache jira account,
and the sign up is not working well, it always return the form i submit
without error msg.
Joe
On Sat, Nov 29, 2014 at 7:05 AM, Robert (Bobby) Evans <
[email protected]> wrote:
> I like the change, but supervisor_test.clj needs to be updated too (same
> chage as before). It would also be good if you could file a JIRA for this
> at http://issues.apache.org/jira, for tracking purposes. Other then that
> I am +1.
>
> Oh I ran the full set of unit tests with clojure-1.6.0 and they all
> passed, might be worth updating that too.
>
> diff --git a/pom.xml b/pom.xml
> index 5645b9a..233c7ba 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -180,7 +180,7 @@
>
<test.extra.args>-Djava.net.preferIPv4Stack=true</test.extra.args>
>
> <!-- dependency versions -->
> - <clojure.version>1.5.1</clojure.version>
> + <clojure.version>1.6.0</clojure.version>
> <compojure.version>1.1.3</compojure.version>
> <hiccup.version>0.3.6</hiccup.version>
> <commons-io.version>2.4</commons-io.version>
> diff --git a/storm-core/test/clj/backtype/storm/supervisor_test.clj
b/storm-core/test/clj/backtype/storm/supervisor_test.clj
> index a3594a3..4157c83 100644
> --- a/storm-core/test/clj/backtype/storm/supervisor_test.clj
> +++ b/storm-core/test/clj/backtype/storm/supervisor_test.clj
> @@ -517,7 +517,7 @@
> (defn found? [sub-str input-str]
> (if (string? input-str)
> (contrib-str/substring? sub-str (str input-str))
> - (some? #(contrib-str/substring? sub-str %) input-str)))
> + (boolean (some #(contrib-str/substring? sub-str %) input-str))))
>
> (defn not-found? [sub-str input-str]
> (complement (found? sub-str input-str)))
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/storm/pull/285#issuecomment-64933603>.
>
--
Zhou Xiangtao
Email: [email protected]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
