[
https://issues.apache.org/jira/browse/STORM-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14237918#comment-14237918
]
ASF GitHub Bot commented on STORM-585:
--------------------------------------
GitHub user fmazoyer opened a pull request:
https://github.com/apache/storm/pull/342
Storm 585
Hello, I just fixed the issue I found :
https://issues.apache.org/jira/browse/STORM-585.
I pushed it to my fork, into branch STORM-585.
As this is my first pull request from my fork, I just hope I didn't do
anything stupid and that I'm following the process correctly...
Please review the changes; do not hesitate to get back to me :-)
Thanks a lot for your help, and letting me contribute to this great
project!!!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fmazoyer/storm STORM-585
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/342.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #342
----
commit da7da2c494dbe96f73a6fab5499d44c877b774c7
Author: lewuathe <[email protected]>
Date: 2014-11-19T22:06:49Z
Typo in storm-kafka README
commit 3899a95281804ddbb820cebc03a7374783435a3e
Author: Sriharsha Chintalapani <[email protected]>
Date: 2014-11-20T16:36:17Z
STORM-565. Setting topology.groups to nil could break SimpleACLAuthorizer.
commit bd86e5e6c60daf46008c8004ff266d395933f62b
Author: Kishor Patil <[email protected]>
Date: 2014-11-21T13:34:52Z
Add Configuration to enable/disable Bolt's outgoing overflow-buffer
commit 501ae80d36ef717a1541715cc68d394f7ca5c571
Author: Sriharsha Chintalapani <[email protected]>
Date: 2014-11-22T19:45:51Z
STORM-571. upgrade clj-time.
commit 40157f9755ec2c824167d1569ae2b1bb5848e646
Author: Ahmet DAL <[email protected]>
Date: 2014-11-24T13:42:12Z
STORM-573 is fixed. timeout-ms value can be passed as param to
comlete-topology in testing4j.clj for Java projects.
commit 33049857cbe74b7d73836d70f890c4097748af8c
Author: Robert (Bobby) Evans <[email protected]>
Date: 2014-11-28T22:04:18Z
Added STORM-573 to Changelog and README.
commit 0febff4e5f0364359aad11e148d8462b3b9744bf
Author: Robert (Bobby) Evans <[email protected]>
Date: 2014-11-28T22:18:42Z
Added STORM-571 to Changelog
commit 05dcac861d04aea04f7ff8ee591e6ebd558f1814
Author: Robert (Bobby) Evans <[email protected]>
Date: 2014-11-28T22:34:14Z
Added STORM-569 to changelog.
commit 341b3968c80ca6d2af0e6f7e0dd6a6215271dd68
Author: Robert (Bobby) Evans <[email protected]>
Date: 2014-11-28T22:46:44Z
Added STORM-565 to Changelog
commit b40ecbf6a2272d9eea9d27e71646f80808b2b20a
Author: Robert (Bobby) Evans <[email protected]>
Date: 2014-11-29T19:09:18Z
Added PULL #320 to Readme.
commit 6463f6cbe3b460005a749509e0ac86487728dac9
Author: Frantz Mazoyer <[email protected]>
Date: 2014-12-08T12:50:26Z
Fix for JIRA https://issues.apache.org/jira/browse/STORM-585
commit 384a22637b65b909f4ae13f40a6560ba97b96fb8
Author: Frantz Mazoyer <[email protected]>
Date: 2014-12-08T12:56:25Z
Merge remote-tracking branch 'upstream/master' into STORM-585
----
> Performance issue in none grouping
> ----------------------------------
>
> Key: STORM-585
> URL: https://issues.apache.org/jira/browse/STORM-585
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 0.9.2-incubating, 0.9.3, 0.10.0, 0.9.3-rc2
> Reporter: Frantz Mazoyer
> Assignee: Frantz Mazoyer
> Priority: Minor
> Fix For: 0.10.0
>
>
> In function mk-grouper, target-tasks is originally a ^List
> It then becomes a clojure vector:
> ...
> target-tasks (vec (sort target-tasks))]
> ...
> In :none grouping case, java method '.get' is called on target-tasks object:
> ...
> (.get target-tasks i)
> ...
> At run time, clojure will use introspection to find a method with a matching
> name and signature, which is very costly.
> Using clojure built-in vector 'get' function instead of '.get' method made us
> gain 25% performance in our use-case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
