[
https://issues.apache.org/jira/browse/STORM-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14246652#comment-14246652
]
ASF GitHub Bot commented on STORM-593:
--------------------------------------
Github user tedxia commented on the pull request:
https://github.com/apache/storm/pull/349#issuecomment-66996013
The write lock only protect cached-task->node+port, and not protect
cached-node+port->socket.
@nathanmarz If we want to ensure send never called on a closed connection,
should we also protect cached-node+port->socket either?
> No need of rwlock for clojure atom
> -----------------------------------
>
> Key: STORM-593
> URL: https://issues.apache.org/jira/browse/STORM-593
> Project: Apache Storm
> Issue Type: Improvement
> Affects Versions: 0.10.0
> Reporter: xiajun
> Assignee: xiajun
>
> cached-node+port->socket in worker-data is atom, there on need for rwlock
> endpoint-socket-lock to protect cached-node+port->socket. And after use
> rwlock, there will be competition between refresh-connections and message
> send.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
