[
https://issues.apache.org/jira/browse/STORM-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14267846#comment-14267846
]
ASF GitHub Bot commented on STORM-248:
--------------------------------------
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/373#discussion_r22597312
--- Diff: bin/storm ---
@@ -312,6 +312,13 @@ def repl():
cppaths = [CLUSTER_CONF_DIR]
exec_storm_class("clojure.main", jvmtype="-client", extrajars=cppaths)
+def get_logback_conf_dir():
+ cppaths = [CLUSTER_CONF_DIR]
+ storm_logback_conf_dir = confvalue("storm.logback.conf.dir", cppaths)
+ if(storm_logback_conf_dir == None or storm_logback_conf_dir == "nil"):
--- End diff --
Here storm_logback_conf_dir == "nil" will match if the
storm_logback_conf_dir is set to "nil" . I think you meant to check if the
string is empty, a better way probably is "if not storm_logback_conf"
> cluster.xml location is hardcoded for workers.
> ----------------------------------------------
>
> Key: STORM-248
> URL: https://issues.apache.org/jira/browse/STORM-248
> Project: Apache Storm
> Issue Type: Bug
> Reporter: Edward Goslin
> Assignee: Frantz Mazoyer
> Priority: Trivial
>
> when the supervisor spawns a worker process, it assumes the cluster.xml is in
> -Dlogback.configurationFile=" storm-home "/logback/cluster.xml"
> It should take the VM arguement for the supervisor and pass it down to the
> worker.
> System.get("logback.configurationFile", storm-home + "/logback/cluster.xml)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
