Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/360#issuecomment-69399742
For the most part this looks good and I am +1 on merging this in. However,
I was wondering why we don't just replace the the backtype.storm.util
url-encode with the ring version? or delete it and replace all of the calls to
it everywhere. If it doesn't do the right thing we should stop using it
everywhere.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
