Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/294#issuecomment-69603185
@caofangkun
The changes look good to me now. I am still a bit nervous that this will
not build on windows, but that can be fixed later. I would also like the
comments by @mnogu addressed. After that I am +1 on this.
Thanks for the work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
