Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/385#issuecomment-70574408
@rekhajoshm Thanks for the patch. Few observations here
1) you are changing interfaces to pass a codeDir param. I can't find it
where codeDir used to fixed this issue. Whenever you are changing apis like
this you should introduce a new method definition not change the existing ones
as these are storm-core apis. Please also explain whats the necessity of
codeDir.
2) you added dependency-reduced-pom.xml and any reason to remove
org.clojars.runa from pom.xml. Also maven-eclipse.xml shouldn't be part of this
commit.
I am -1 on the current approach, changing apis to solve this is not a good
idea. This pretty much breaks current topologies.
I suggest you to look into ui/core.clj , one approach is to have a search
functionality in logviewer and provide a link next to error message with param
to logviewer as the errormessage. When user clicks on that it goes to logviewer
and highlight the error in the log file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
