Github user Parth-Brahmbhatt commented on a diff in the pull request:

    https://github.com/apache/storm/pull/392#discussion_r23393694
  
    --- Diff: storm-core/src/storm.thrift ---
    @@ -243,6 +243,16 @@ struct SubmitOptions {
       2: optional Credentials creds;
     }
     
    +enum NumErrorsChoice {
    +  ALL,
    +  NONE,
    +  ONE
    +}
    +
    +struct GetInfoOptions {
    +  1: optional NumErrorsChoice num_err_choice;
    --- End diff --
    
    Instead of an Enum don't you think a pagination struct with a start and end 
would be more flexible? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to