Github user ogorun commented on the pull request:

    https://github.com/apache/storm/pull/406#issuecomment-72620333
  
    @wurstmeister ,
    Thank you for pointing me to https://github.com/apache/storm/pull/254  .
    It is definitely progress in direction of failure handling functionality 
encapsulation. But there are two points that I'would solve another way. 
    
    * I feel plugable failure handler (with reasonable default) is needed. For 
example, I'd rather have one point in topology (spout) that decides when to 
stop  reprocessing the same message (for example, after configurable number of 
retries) than checking all possible exceptions are handled properly in every 
bolt.
    
    * fail() event is divided into two parts: one part is handled in 
PartitionManager class and another one in FailedMsgRetryManager. I don't see 
cause for such division.
    
    
    
     


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to