[
https://issues.apache.org/jira/browse/STORM-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304668#comment-14304668
]
ASF GitHub Bot commented on STORM-487:
--------------------------------------
Github user dashengju commented on the pull request:
https://github.com/apache/storm/pull/280#issuecomment-72793961
@harshach @HeartSaVioR @revans2 , this PR has produce a new bug in linux
OS.
In function exec_storm_class，line 181:
- os.execvp(JAVA_CMD, all_args) # replaces the current process and
- # never returns
+ # handling whitespaces in JAVA_CMD
+ sub.call(all_args)
The origin code execute JAVA_CMD in exec style(replaces the current process
and never returns), But the new code execute JAVA_CMD in sub process.
Usually, nimbus/supervisor is running by daemon tools, so when
nimbus/supervisor run in sub process, daemon tools can not stop the
nimbus/supervisor process.
> Remove storm.cmd, no need to duplicate work python runs on windows too.
> -----------------------------------------------------------------------
>
> Key: STORM-487
> URL: https://issues.apache.org/jira/browse/STORM-487
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: Robert Joseph Evans
> Assignee: Jungtaek Lim
> Labels: newbie
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
