[
https://issues.apache.org/jira/browse/STORM-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14307374#comment-14307374
]
ASF GitHub Bot commented on STORM-441:
--------------------------------------
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/237#discussion_r24169449
--- Diff: storm-core/src/clj/backtype/storm/daemon/executor.clj ---
@@ -52,7 +60,7 @@
))
(defn- mk-grouper
- "Returns a function that returns a vector of which task indices to send
tuple to, or just a single task index."
+ "returns a function that returns a vector of which task indices to send
tuple to, or just a single task index."
--- End diff --
Must be.
> Remove bootstrap macro from Clojure codebase
> --------------------------------------------
>
> Key: STORM-441
> URL: https://issues.apache.org/jira/browse/STORM-441
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: Dane Hammer
> Priority: Trivial
>
> The bootstrap macro in backtype.storm.bootstrap is purely a convenience for
> importing/using/requiring a large number of dependencies, but it's not used
> for anything else. It removes those imports/uses/requires from the namespace
> form, making it harder to track down where a definition is coming from, which
> defeats some IDE tools.
> I propose removing it entirely, making the Clojure part of the codebase more
> readable and updated to current conventions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
