Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/417#discussion_r24178855
--- Diff: storm-core/src/clj/backtype/storm/daemon/common.clj ---
@@ -312,7 +312,7 @@
))
(defn has-ackers? [storm-conf]
- (or (nil? (storm-conf TOPOLOGY-ACKER-EXECUTORS)) (> (storm-conf
TOPOLOGY-ACKER-EXECUTORS) 0)))
+ (and (not (nil? (storm-conf TOPOLOGY-ACKER-EXECUTORS))) (> (storm-conf
TOPOLOGY-ACKER-EXECUTORS) 0)))
--- End diff --
Or leave out both `not` and `nil`? Would that also work here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
