Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/414#discussion_r24342731
--- Diff: storm-core/src/clj/backtype/storm/converter.clj ---
@@ -0,0 +1,200 @@
+(ns backtype.storm.converter
--- End diff --
I personally would rather see the code use the Thrift objects directly.
One of the reasons I wanted to have Thrift over just using maps, was that it
would force a developer to think about any changes that make. To me having
this here means that someone will add something to Assignment for example and
not update this. Then it will work just fine in local mode testing, but will
not work in a real cluster, and would be a pain to debug.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
