[
https://issues.apache.org/jira/browse/STORM-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14316528#comment-14316528
]
ASF GitHub Bot commented on STORM-657:
--------------------------------------
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/421#discussion_r24511333
--- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj ---
@@ -257,7 +258,9 @@
(if as-user
(worker-launcher-and-wait conf user ["signal" pid "9"] :log-prefix
(str "kill -15 " pid))
(kill-process-with-sig-term pid)))
- (if-not (empty? pids) (sleep-secs 1)) ;; allow 1 second for execution
of cleanup threads on worker.
+ (if-not (empty? pids) (do
+ (log-message "Sleep " shutdown-sleep-secs "
seconds for execution of cleanup threads on worker.")
+ (sleep-secs shutdown-sleep-secs)))
--- End diff --
To clean this up a tiny bit, this can be:
```clojure
(when-not (empty? pids)
(log-message ...)
(sleep-secs ...))
```
> make the shutdown-worker sleep time before kill -9 configurable
> ---------------------------------------------------------------
>
> Key: STORM-657
> URL: https://issues.apache.org/jira/browse/STORM-657
> Project: Apache Storm
> Issue Type: Improvement
> Affects Versions: 0.9.2-incubating, 0.10.0
> Reporter: Vincent Russell
> Assignee: caofangkun
> Priority: Minor
>
> This is a continuation of STORM-183: Supervisor/worker shutdown hook should
> be called in distributed mode.
> It would be nice to be able to configure how many seconds (or millis) to
> sleep for before shutting down the worker process in the shutdown-worker
> function in supervisor.clj
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
