[
https://issues.apache.org/jira/browse/STORM-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329654#comment-14329654
]
ASF GitHub Bot commented on STORM-683:
--------------------------------------
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/438
STORM-683: Make false in a conf really evaluate to false in clojure.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-683
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/438.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #438
----
commit b734bab833f6c12d406e2b2e1db7303f2342066f
Author: Robert (Bobby) Evans <[email protected]>
Date: 2015-02-20T22:12:02Z
STORM-683: Make false in a conf really evaluate to false in clojure.
----
> Configs set to false do not always evaluate to false.
> -----------------------------------------------------
>
> Key: STORM-683
> URL: https://issues.apache.org/jira/browse/STORM-683
> Project: Apache Storm
> Issue Type: Bug
> Reporter: Robert Joseph Evans
> Priority: Blocker
>
> We just ran into a situation where for a specific boolean config a user was
> setting it to false, and it was evaluating as true.
> Turns out this is expected behavior
> http://dev.clojure.org/jira/browse/CLJ-1640
> The issue comes up that (Boolean. false) is not the same as Boolean/FALSE and
> can evaluate to true, but the way we deserialize the config (using JSON) all
> the booleans are the bad form.
> Ideally we cleanup the deserialization code to look for booleans and
> translate them to the appropriate values. This feels cleaner than trying to
> have every place we access a config try to convert it first.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
