Github user d2r commented on a diff in the pull request:

    https://github.com/apache/storm/pull/312#discussion_r25610339
  
    --- Diff: storm-core/src/clj/backtype/storm/stats.clj ---
    @@ -67,7 +67,7 @@
     (defrecord RollingWindowSet [updater extractor windows all-time])
     
     (defn rolling-window-set [updater merger extractor num-buckets & 
bucket-sizes]
    -  (RollingWindowSet. updater extractor (dofor [s bucket-sizes] 
(rolling-window updater merger extractor s num-buckets)) nil)
    +  (RollingWindowSet. updater extractor (dofor [s bucket-sizes] 
(rolling-window updater merger extractor num-buckets s)) nil)
    --- End diff --
    
    This breaks the call to `rolling-window`. Please revert.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to