[
https://issues.apache.org/jira/browse/STORM-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348837#comment-14348837
]
ASF GitHub Bot commented on STORM-477:
--------------------------------------
GitHub user ppoulosk opened a pull request:
https://github.com/apache/storm/pull/457
[STORM-477] Add warning for invalid JAVA_HOME
This adds a check in the python script to ensure that JAVA_HOME points to
an installation of storm, and prints an error message if it is not properly set.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ppoulosk/storm STORM-477
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/457.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #457
----
commit fc3dd60798c158a26380a931b31325249ca7af16
Author: Paul Poulosky <[email protected]>
Date: 2015-03-05T14:58:38Z
Add warning for invalid JAVA_HOME
----
> Incorrectly set JAVA_HOME is not detected
> -----------------------------------------
>
> Key: STORM-477
> URL: https://issues.apache.org/jira/browse/STORM-477
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 0.9.2-incubating
> Environment: Rhel6
> Reporter: Paul Poulosky
> Assignee: Oleg Ostashchuk
> Priority: Minor
> Labels: newbie
>
> If JAVA_HOME is incorrectly set in a user's environment when launching storm,
>
> it fails with an error message that is confusing to end users.
> Traceback (most recent call last):
> File "/home/y/bin/storm", line 485, in <module>
> main()
> File "/home/y/bin/storm", line 482, in main
> (COMMANDS.get(COMMAND, unknown_command))(*ARGS)
> File "/home/y/bin/storm", line 225, in listtopos
> extrajars=[USER_CONF_DIR, STORM_DIR + "/bin"])
> File "/home/y/bin/storm", line 153, in exec_storm_class
> ] + jvmopts + [klass] + list(args)
> File "/home/y/bin/storm", line 97, in confvalue
> p = sub.Popen(command, stdout=sub.PIPE)
> File "/usr/lib64/python2.6/subprocess.py", line 642, in __init__
> errread, errwrite)
> File "/usr/lib64/python2.6/subprocess.py", line 1234, in _execute_child
> raise child_exception
> It would be nice if this were either detected and a proper error message
> printed, or if it warned and fell back to the java found in PATH.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
