[
https://issues.apache.org/jira/browse/STORM-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14365428#comment-14365428
]
ASF GitHub Bot commented on STORM-702:
--------------------------------------
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/432#discussion_r26588593
--- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
@@ -363,9 +384,30 @@ public static CuratorFramework newCurator(Map conf,
List<String> servers, Object
return builder.build();
}
- protected static void setupBuilder(CuratorFrameworkFactory.Builder
builder, String zkStr, Map conf, ZookeeperAuthInfo auth)
+ protected static void setupBuilder(CuratorFrameworkFactory.Builder
builder, final String zkStr, Map conf, ZookeeperAuthInfo auth)
{
- builder.connectString(zkStr)
+ List<String> exhibitorServers =
getStrings(conf.get(Config.STORM_EXHIBITOR_SERVERS));
+ if (!exhibitorServers.isEmpty()) {
+ // use exhibitor servers
+ builder.ensembleProvider(new ExhibitorEnsembleProvider(
+ new Exhibitors(exhibitorServers,
Utils.getInt(conf.get(Config.STORM_EXHIBITOR_PORT), 8080),
--- End diff --
Instead of having 8080 as port here in the code can you add it to
defaults.yaml
> Apache Exhibitor support
> ------------------------
>
> Key: STORM-702
> URL: https://issues.apache.org/jira/browse/STORM-702
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: Aaron Dixon
> Priority: Critical
>
> Storm connects to Zookeeper via an explicit list of zookeeper hosts.
> Apache Exhibitor offers zookeeper cluster discovery and management features
> allowing for dynamically resizing zookeeper clusters, restarting and
> replacing zk machines in the cluster, etc.
> Curator supports creating zookeeper client connections using exhibitor hosts.
> Storm should allow (optionally) for connection to its Zookeeper clusters
> through Exhibitor.
> Here is the github pull request that prompted this ticket, and that
> introduces optional exhibitor configuration and exhibitor support in Storm:
> https://github.com/apache/storm/pull/432
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
