[
https://issues.apache.org/jira/browse/STORM-720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376880#comment-14376880
]
ASF GitHub Bot commented on STORM-720:
--------------------------------------
GitHub user rtandonmsft opened a pull request:
https://github.com/apache/storm/pull/476
STORM-720: Storm.cmd should return ERRORLEVEL before exiting main block
PR for https://issues.apache.org/jira/browse/STORM-720
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rtandonmsft/storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/476.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #476
----
commit 4004314203225af80474611a2084b1cade2f71ec
Author: Ravi Tandon <[email protected]>
Date: 2015-03-23T23:13:31Z
STORM-720: Storm.cmd should return ERRORLEVEL before exiting main block
----
> Storm.cmd should return ERRORLEVEL before exiting main block
> ------------------------------------------------------------
>
> Key: STORM-720
> URL: https://issues.apache.org/jira/browse/STORM-720
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 0.9.3, 0.9.4
> Reporter: Ravi Tandon
> Assignee: Ravi Tandon
> Priority: Trivial
> Fix For: 0.9.3, 0.9.4
>
> Attachments: storm_cmd_exitcode_rev0.patch
>
>
> This JIRA is for a very small PR that I will post soon (attached patch)
> Issue: The Storm.cmd does not exit with an ErrorLevel.
> Impact: Any automation via windows banks on return or exit code from the
> program to determine success.
> When can this occur: Passing wrong arguments (like wrong class name or bad
> topology builder code) to java will result in error and any automation
> program will check on the exit code.
> FYI @ [~harsha_ch] [~shanyu]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
