[
https://issues.apache.org/jira/browse/STORM-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381940#comment-14381940
]
ASF GitHub Bot commented on STORM-587:
--------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/475#issuecomment-86539624
This is the path I saw through the code. Please let me know if I missed
anything.
https://github.com/apache/storm/blob/master/storm-core/src/jvm/storm/trident/topology/state/TransactionalState.java#L53
https://github.com/apache/storm/blob/master/storm-core/src/jvm/storm/trident/spout/TridentSpoutCoordinator.java#L56
https://github.com/apache/storm/blob/master/storm-core/src/jvm/storm/trident/spout/TridentSpoutCoordinator.java#L48-51
https://github.com/apache/storm/blob/master/storm-core/src/jvm/storm/trident/topology/TridentTopologyBuilder.java#L160
https://github.com/apache/storm/blob/master/storm-core/src/jvm/storm/trident/topology/TridentTopologyBuilder.java#L278-282
https://github.com/apache/storm/blob/master/storm-core/src/jvm/storm/trident/topology/TridentTopologyBuilder.java#L71-76
https://github.com/apache/storm/blob/master/storm-core/src/jvm/storm/trident/TridentTopology.java#L403
https://github.com/apache/storm/blob/master/storm-core/src/jvm/storm/trident/planner/SpoutNode.java#L33-35
https://github.com/apache/storm/blob/master/storm-core/src/jvm/storm/trident/TridentTopology.java#L119-122
I am a bit nervous about breaking backwards compatibility without a
migration path. I would be OK with the change if we had a tool that could
upgrade/downgrade a trident topology state. I suppose it would be OK to also
have an option to not include the topology name, but I would prefer to not have
to deal with that from a state perspective.
> trident transactional state in zk should be namespaced with topology id
> -----------------------------------------------------------------------
>
> Key: STORM-587
> URL: https://issues.apache.org/jira/browse/STORM-587
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: Parth Brahmbhatt
> Assignee: Sriharsha Chintalapani
>
> Currently when a trident transaction spout is initialized it creates a node
> in zk under /transactional with the spout name as the node's name. This is
> pretty dangerous as any other topology can be submitted with same spout name
> and now these 2 spouts will be overwriting each other's states. I believe it
> is better to namespace this with topologyId just like all other zk entries
> under /storm.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
