[
https://issues.apache.org/jira/browse/STORM-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14389493#comment-14389493
]
ASF GitHub Bot commented on STORM-742:
--------------------------------------
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/497
STORM-742 Let ShellBolt treat all messages to update heartbeat
It's for avoiding design constraint being introduced from STORM-513.
ShellSpout is already applied.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-742
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/497.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #497
----
commit b815012509e15a68bdd72cc684ab5cc91dd53b86
Author: Jungtaek Lim <[email protected]>
Date: 2015-03-31T22:02:09Z
STORM-742 Let ShellBolt treat all messages to update heartbeat
----
> Very busy ShellBolt subprocess cannot respond heartbeat just in time
> --------------------------------------------------------------------
>
> Key: STORM-742
> URL: https://issues.apache.org/jira/browse/STORM-742
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 0.9.3, 0.10.0, 0.9.4, 0.11.0
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
> Priority: Critical
>
> As [~dashengju] stated from STORM-738, very busy ShellBolt subprocess cannot
> respond heartbeat just in time.
> Actually it's by design constraint (more details are on STORM-513 or
> STORM-738), but ShellSpout avoids constraint by updating heartbeat at any
> type of response from subprocess.
> We can apply this approach to ShellBolt and let ShellBolt avoid design
> constraint, too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
