Github user lazyval commented on a diff in the pull request:
https://github.com/apache/storm/pull/495#discussion_r27571878
--- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
@@ -135,35 +137,68 @@ public static void sleep(long millis) {
}
public static Map findAndReadConfigFile(String name, boolean
mustExist) {
+ InputStream in = null;
+ Boolean confFileEmpty = false;
--- End diff --
There are two variables types in Java: primitive (like boolean, int, long,
short and so on), and their boxed counterparts (Boolean, Integer, Long, ...),
which are seen as reference types. It's minor, but unless you're working with
collections, there is no need to use later one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
