[
https://issues.apache.org/jira/browse/STORM-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14390596#comment-14390596
]
ASF GitHub Bot commented on STORM-188:
--------------------------------------
Github user lazyval commented on a diff in the pull request:
https://github.com/apache/storm/pull/495#discussion_r27571878
--- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
@@ -135,35 +137,68 @@ public static void sleep(long millis) {
}
public static Map findAndReadConfigFile(String name, boolean
mustExist) {
+ InputStream in = null;
+ Boolean confFileEmpty = false;
--- End diff --
There are two variables types in Java: primitive (like boolean, int, long,
short and so on), and their boxed counterparts (Boolean, Integer, Long, ...),
which are seen as reference types. It's minor, but unless you're working with
collections, there is no need to use later one.
> Allow user to specify full configuration path when running storm command
> ------------------------------------------------------------------------
>
> Key: STORM-188
> URL: https://issues.apache.org/jira/browse/STORM-188
> Project: Apache Storm
> Issue Type: Bug
> Reporter: Sean Zhong
> Priority: Minor
> Attachments: search_local_path_for_config.patch, storm-188.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Currently, storm will only look up configuration path in java classpath. We
> should also allow user to specify full configuration path. This is very
> important for a shared cluster environment, like YARN. Multiple storm cluster
> may runs with different configuration, but share same binary folder.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
