[ 
https://issues.apache.org/jira/browse/STORM-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14481724#comment-14481724
 ] 

ASF GitHub Bot commented on STORM-750:
--------------------------------------

Github user ptgoetz commented on the pull request:

    https://github.com/apache/storm/pull/507#issuecomment-90218104
  
    @revans2 I thought about that (-1 to force a revert), but I decided against 
it. It was an honest mistake made in the spirit of adhering to the bylaws. As I 
mentioned earlier it is such an innocuous change that I doubt anyone would be 
against it.
    
    Nonetheless, in the future I think we should stick with the 24-hour 
guideline.
    
    I'm +1 for leaving it as is, if anyone disagrees, we can always revert.


> Set Serialization Id for Config
> -------------------------------
>
>                 Key: STORM-750
>                 URL: https://issues.apache.org/jira/browse/STORM-750
>             Project: Apache Storm
>          Issue Type: Bug
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>              Labels: newbie
>             Fix For: 0.11.0
>
>
> We have had several customers write bolts or spouts that don't do the right 
> thing and end up caching the Config somewhere in the bolt or spout instance.  
> Sometimes in odd ways through anonymous inner classes that should have been 
> static but were not and debugging them because of the bad java serialization 
> errors is really hard.
> Instead of beating on them to clean up these references every time we upgrade 
> a cluster, or force them to keep their client perfectly in sync with the 
> server, I propose that we set the serialization id for Config.  Config stores 
> no state except in the parent class so it really should not matter if we add 
> more methods to it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to