[ 
https://issues.apache.org/jira/browse/STORM-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484203#comment-14484203
 ] 

ASF GitHub Bot commented on STORM-721:
--------------------------------------

Github user Parth-Brahmbhatt commented on a diff in the pull request:

    https://github.com/apache/storm/pull/479#discussion_r27926806
  
    --- Diff: storm-core/src/clj/backtype/storm/ui/core.clj ---
    @@ -1078,10 +1078,32 @@
         (let [conf *STORM-CONF*
               header-buffer-size (int (.get conf UI-HEADER-BUFFER-BYTES))
               filters-confs [{:filter-class (conf UI-FILTER)
    -                          :filter-params (conf UI-FILTER-PARAMS)}]]
    +                          :filter-params (conf UI-FILTER-PARAMS)}]
    +          https-port (if (not-nil? (conf UI-HTTPS-PORT)) (conf 
UI-HTTPS-PORT) 0)
    +          https-ks-path (conf UI-HTTPS-KEYSTORE-PATH)
    +          https-ks-password (conf UI-HTTPS-KEYSTORE-PASSWORD)
    +          https-ks-type (conf UI-HTTPS-KEYSTORE-TYPE)
    +          https-key-password (conf UI-HTTPS-KEY-PASSWORD)
    +          https-ts-path (conf UI-HTTPS-TRUSTSTORE-PATH)
    +          https-ts-password (conf UI-HTTPS-TRUSTSTORE-PASSWORD)
    +          https-ts-type (conf UI-HTTPS-TRUSTSTORE-TYPE)
    +          https-want-client-auth (conf UI-HTTPS-WANT-CLIENT-AUTH)
    --- End diff --
    
    Same here, we should add the documentation to SECURITY.MD.


> Storm UI server should support SSL
> ----------------------------------
>
>                 Key: STORM-721
>                 URL: https://issues.apache.org/jira/browse/STORM-721
>             Project: Apache Storm
>          Issue Type: Improvement
>            Reporter: Sriharsha Chintalapani
>            Assignee: Sriharsha Chintalapani
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to