[
https://issues.apache.org/jira/browse/STORM-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14488047#comment-14488047
]
ASF GitHub Bot commented on STORM-764:
--------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/517#discussion_r28093532
--- Diff:
storm-core/src/jvm/backtype/storm/serialization/GzipBridgeThriftSerializationDelegate.java
---
@@ -0,0 +1,65 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package backtype.storm.serialization;
+
+import java.util.Map;
+import java.util.zip.GZIPInputStream;
+
+/**
+ * Always writes gzip out, but tests incoming to see if it's gzipped. If
it is, deserializes with gzip. If not, uses
+ * {@link backtype.storm.serialization.DefaultSerializationDelegate} to
deserialize. Any logic needing to be enabled
+ * via {@link #prepare(java.util.Map)} is passed through to both delegates.
+ */
+@Deprecated
--- End diff --
Great catch, this is a copy paste error. I'll fix it.
> Have option to compress thrift heartbeat
> ----------------------------------------
>
> Key: STORM-764
> URL: https://issues.apache.org/jira/browse/STORM-764
> Project: Apache Storm
> Issue Type: New Feature
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
>
> In my experiments heartbeats can be gzip compressed to 1/10th the original
> thrift size. This appears to be because there is a lot of plain text in the
> heartbeat that is often repeated. We should offer compression like we were
> doing for java serialization.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
