[
https://issues.apache.org/jira/browse/STORM-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498254#comment-14498254
]
ASF GitHub Bot commented on STORM-787:
--------------------------------------
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/523
[STORM-787]: test-ns should announce test failures with 'BUILD FAILURE'
Slightly more complicated clojure.
The only thing really changing here is that it checks the values for the
`:fail` and `:error` keys in the return value of `run-tests`
In case of error, `System.exit(1)`.
In the python, propagate the exit code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knusbaum/incubator-storm STORM-787
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/523.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #523
----
commit 5af2e3c784e6dae97fb69521c06898c1be8e5d00
Author: Kyle Nusbaum <[email protected]>
Date: 2015-04-16T16:35:44Z
Updating test-ns.py
----
> test-ns should announce test failures with 'BUILD FAILURE'
> ----------------------------------------------------------
>
> Key: STORM-787
> URL: https://issues.apache.org/jira/browse/STORM-787
> Project: Apache Storm
> Issue Type: Bug
> Reporter: Kyle Nusbaum
> Assignee: Kyle Nusbaum
> Priority: Trivial
>
> Right now, test-ns.py exits with return code 0 and prints 'BUILD SUCCESS'
> even when tests fail. You have to look at the test tuple to tell if the tests
> actually passed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
