Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/529#issuecomment-94460394
Overall the code looks good. The trick with the rolling upgrade is that we
want to be sure that an old nimbus can work with a new supervisor and a new
nimbus can work with an old supervisor too. Similarly for the client. An old
client should be able to work with a new nimbus and a new client should, in
most cases, work with an old nimbus. Perhaps the simples way to do this is to
provide a default value for version which is set to something like "VERSION NOT
PROVIDED".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
