[
https://issues.apache.org/jira/browse/STORM-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502942#comment-14502942
]
ASF GitHub Bot commented on STORM-790:
--------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/527#issuecomment-94471958
@HeartSaVioR
Looking at the code prior to
https://github.com/apache/storm/commit/861a92eab8740cfc0f83ac4d7ade9a2ab04a8b9b
null routing was silently ignored. I'm not sure that was on purpose though. I
am OK merging this in, but I really would like to understand why the
destination task is showing up as null occasionally, but I see that you
addressed that in the comments here
https://issues.apache.org/jira/browse/STORM-770?focusedCommentId=14499225&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14499225
So I am +1 for the change. At least now we explicitly handle the situation.
> Log "task id is null" instead of let worker died (NPE in consumeBatchToCursor)
> ------------------------------------------------------------------------------
>
> Key: STORM-790
> URL: https://issues.apache.org/jira/browse/STORM-790
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 0.9.2-incubating, 0.9.3, 0.10.0, 0.9.4, 0.11.0
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
>
> In STORM-770, some users have observed that worker suddenly died with NPE in
> consumeBatchToCursor().
> Looks like it can occur when "task" in "mk-transfer-fn" is null.
> It may not be an issue before 0.9.2-incubating, since worker just ignores
> that tuple.
> Please see
> https://issues.apache.org/jira/browse/STORM-770?focusedCommentId=14496199&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14496199.
> Before finding root cause of this issue, it would be better to let worker not
> killed by this issue but just log with WARN or ERROR level.
> It really makes sense cause before 0.9.2 Storm silently ignores tuple, and
> with Guaranteeing Message Processing, after timed-out tuple will be replayed.
> (It isn't applied to non-ack)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
