Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/525#issuecomment-94496477
@dan-blanchard thanks for all of the work you have done. I did a pass
through the code and I had a few nits about whitespace (not important) and I
was curious what you though about changing the way the grouping conversion
works. If you don't really want to change it, I am fine with that.
My only other comment would be around documentation. Please update
https://github.com/apache/storm/blob/master/docs/documentation/Multilang-protocol.md
to include the new information, and mark that these changes are a part of
0.11.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
