[ 
https://issues.apache.org/jira/browse/STORM-806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14519382#comment-14519382
 ] 

ASF GitHub Bot commented on STORM-806:
--------------------------------------

Github user HeartSaVioR commented on the pull request:

    https://github.com/apache/storm/pull/540#issuecomment-97436721
  
    Build is failed from ZkCoordinatorTest.
    You should also provide Config.STORM_ZOOKEEPER_CONNECTION_TIMEOUT from 
ZkCoordinatorTest to let build passed.
    
    ```
        private Map buildZookeeperConfig(TestingServer server) {
            Map conf = new HashMap();
            conf.put(Config.TRANSACTIONAL_ZOOKEEPER_PORT, server.getPort());
            conf.put(Config.TRANSACTIONAL_ZOOKEEPER_SERVERS, 
Arrays.asList("localhost"));
            conf.put(Config.STORM_ZOOKEEPER_SESSION_TIMEOUT, 20000);
            conf.put(Config.STORM_ZOOKEEPER_RETRY_TIMES, 3);
            conf.put(Config.STORM_ZOOKEEPER_RETRY_INTERVAL, 30);
            return conf;
        }
    ```
    
    I recommend you to run tests from dev. machine at least once before posting 
PR.


> use storm.zookeeper.connection.timeout in storm-kafka ZkState when newCurator
> -----------------------------------------------------------------------------
>
>                 Key: STORM-806
>                 URL: https://issues.apache.org/jira/browse/STORM-806
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-kafka
>    Affects Versions: 0.11.0
>            Reporter: xiajun
>            Assignee: xiajun
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to