[ 
https://issues.apache.org/jira/browse/STORM-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537988#comment-14537988
 ] 

ASF GitHub Bot commented on STORM-813:
--------------------------------------

GitHub user HeartSaVioR opened a pull request:

    https://github.com/apache/storm/pull/548

    STORM-813 Change storm-starter's README so that mvn exec:java cannot run 
multilang topology

    New multilang packages rely on supervisor deploy or maven dependency plugin.
    Therefore, storm-starter README should remove example which is not working 
now. 
    
    Btw, actually storm-core shows that it could be possible to unpack 
multilang artifacts with maven plugin and run multilang topology with mvn 
exec:java, and I confirmed that can work with storm-starter.
    
    ```
            <plugin>
                <artifactId>maven-dependency-plugin</artifactId>
                <version>2.8</version>
                <executions>
                    <execution>
                        <id>copy-dependencies</id>
                        <phase>compile</phase>
                        <goals>
                            <goal>copy-dependencies</goal>
                        </goals>
                        <configuration>
                            <overWriteReleases>false</overWriteReleases>
                            <overWriteSnapshots>false</overWriteSnapshots>
                            <overWriteIfNewer>true</overWriteIfNewer>
                            <includeScope>runtime</includeScope>
                        </configuration>
                    </execution>
                    <!-- multi-lang resources -->
                    <execution>
                        <id>unpack</id>
                        <phase>process-resources</phase>
                        <goals>
                            <goal>unpack</goal>
                        </goals>
                        <configuration>
                            <artifactItems>
                                <artifactItem>
                                    <groupId>org.apache.storm</groupId>
                                    <artifactId>multilang-ruby</artifactId>
                                    <version>${project.version}</version>
                                </artifactItem>
                                <artifactItem>
                                    <groupId>org.apache.storm</groupId>
                                    <artifactId>multilang-python</artifactId>
                                    <version>${project.version}</version>
                                </artifactItem>
                                <artifactItem>
                                    <groupId>org.apache.storm</groupId>
                                    
<artifactId>multilang-javascript</artifactId>
                                    <version>${project.version}</version>
                                </artifactItem>
                            </artifactItems>
                            
<outputDirectory>${project.build.directory}/classes</outputDirectory>
                        </configuration>
                    </execution>
                </executions>
            </plugin>
    ```
    
    If we prefer latter approach, I'll change my PR.
    
    Thanks in advance!

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HeartSaVioR/storm STORM-813

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/548.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #548
    
----
commit a448be54543783225671eb7578b872c75645fe3e
Author: Jungtaek Lim <[email protected]>
Date:   2015-05-11T14:21:23Z

    STORM-813 notify mvn exec:java cannot run multilang topology
    
    * New multilang packages rely on supervisor deploy or maven dependency 
plugin

----


> Storm-starter cannot run multilang topology with exec:java with new multilang 
> packages
> --------------------------------------------------------------------------------------
>
>                 Key: STORM-813
>                 URL: https://issues.apache.org/jira/browse/STORM-813
>             Project: Apache Storm
>          Issue Type: Bug
>    Affects Versions: 0.11.0
>            Reporter: Jungtaek Lim
>            Assignee: Jungtaek Lim
>
> After STORM-748, storm-starter doesn't have multilang files now, and just 
> having multilang artifact as dependency.
> With supervisor it works like a charm, but now mvn exec:java with multilang 
> topology doesn't work.
> It would be better to remove broken functionality from README.markdown or 
> make it work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to