[
https://issues.apache.org/jira/browse/STORM-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14548624#comment-14548624
]
ASF GitHub Bot commented on STORM-737:
--------------------------------------
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/521#issuecomment-103187844
> I made another changeset which reverts whole things to 0666c41 (without
try-serialize-local) but leaves TransferDrainer as buffer and grouper (by
host+port).
> HeartSaVioR@6ef2f11
>
> If you think latter is better to move on, I'll post a new PR based on
6ef2f11.
I do prefer the changes on your other branch above those in this pull
request because the other branch is cleaner, but it is up to you. Either way
we will want to be careful.
Thanks for looking at this.
> Workers may try to send to closed connections
> ---------------------------------------------
>
> Key: STORM-737
> URL: https://issues.apache.org/jira/browse/STORM-737
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 0.9.2-incubating
> Reporter: Derek Dagit
>
> There is a race condition in the worker code that can allow for a send() to
> be called on a closed connection.
> [Discussion|https://github.com/apache/storm/pull/349#issuecomment-87778672]
> The assignment mapping from task -> node+port needs to be read and used in
> the read lock when sending, so that an accurate mapping is used that does not
> include any connections that are closed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
