Github user eshioji commented on the pull request:
https://github.com/apache/storm/pull/568#issuecomment-108263716
@revans2 Thanks for the performance testing, I could replicate very similar
results on our machine. I'm trying a few things, hopefully I can get it back to
where it was.
In case you haven't noticed, this change includes fix for
[STORM-839](https://github.com/apache/storm/pull/566) which seems pretty
critical (I actually encountered a deadlock on my live cluster). Do you think
the patch should be applied to 0.9.x if the performance concern is alleviated?
Or are you more thinking of 0.11.x? (I noticed you tested with 0.11)
Also I have a question, maybe @miguno could help; I've removed the graceful
shutdown which tries to flush all pending message before the Client is closed,
mostly to make it easier for me to fix the deadlock. However now I'm worried I
might have removed something significant. Do you think I should bring it back?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
