[ 
https://issues.apache.org/jira/browse/STORM-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573524#comment-14573524
 ] 

ASF GitHub Bot commented on STORM-848:
--------------------------------------

Github user ptgoetz commented on the pull request:

    https://github.com/apache/storm/pull/577#issuecomment-109041007
  
    @kishorvpatil I can't reproduce it. What does your shade config for jetty 
look like?
    
    Here are the sections I added to test:
    
    The include:
    ```xml
    <include>org.eclipse.jetty:*</include>
    ```
    
    The relocation:
    ```xml
                         <pattern>org.eclipse.jetty</pattern>
                                
<shadedPattern>org.apache.storm.jetty</shadedPattern>
                            </relocation>
    ```
    
    I left out the filter @Parth-Brahmbhatt mentioned, expecting to get the 
error you did, but everything succeeded.


> Clean up dependencies and shade as much as possible
> ---------------------------------------------------
>
>                 Key: STORM-848
>                 URL: https://issues.apache.org/jira/browse/STORM-848
>             Project: Apache Storm
>          Issue Type: Improvement
>            Reporter: Robert Joseph Evans
>            Assignee: Kishor Patil
>
> To help with rolling upgrades in the future we should shade as much of our 
> dependencies as possible, so that customers can include their own versions of 
> things.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to