[ 
https://issues.apache.org/jira/browse/STORM-859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14580015#comment-14580015
 ] 

ASF GitHub Bot commented on STORM-859:
--------------------------------------

GitHub user HeartSaVioR opened a pull request:

    https://github.com/apache/storm/pull/588

    STORM-859 Add regression test of STORM-856

    Confirmed that it fails on 27bc183c0f1e33fefb19b640f8a91f563c60ce61 (before 
merging STORM-856), and succeeds on current master.
    
    Please review and comment. Thanks!

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HeartSaVioR/storm STORM-859

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/588.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #588
    
----
commit 12cd098826dba7a7b3a20bf90341449c5130eab8
Author: Jungtaek Lim <[email protected]>
Date:   2015-06-10T04:49:13Z

    STORM-859 Add regression test of STORM-856

----


> Add unit test to prevent regression of STORM-856
> ------------------------------------------------
>
>                 Key: STORM-859
>                 URL: https://issues.apache.org/jira/browse/STORM-859
>             Project: Apache Storm
>          Issue Type: Improvement
>            Reporter: Jungtaek Lim
>            Assignee: Jungtaek Lim
>
> STORM-856 is marked as 'critical', and it has been resolved, but we still 
> open possibilities to make regression in the future.
> I found that it is easy to represent scenario as unit test, so I think we 
> would be better to have it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to