[
https://issues.apache.org/jira/browse/STORM-862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14587415#comment-14587415
]
ASF GitHub Bot commented on STORM-862:
--------------------------------------
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/589#discussion_r32489327
--- Diff: storm-core/src/jvm/backtype/storm/Config.java ---
@@ -1087,6 +1087,17 @@
public static final String TOPOLOGY_METRICS_CONSUMER_REGISTER =
"topology.metrics.consumer.register";
public static final Object TOPOLOGY_METRICS_CONSUMER_REGISTER_SCHEMA =
ConfigValidation.MapsValidator;
+ /**
+ * A map of metric name to class name implementing IMetric that will
be created once per worker JVM
+ */
+ public static final String TOPOLOGY_WORKER_METRICS =
"topology.worker.metrics";
+ public static final Object TOPOLOGY_WORKER_METRICS_SCHEMA = Map.class;
+
+ /**
--- End diff --
Seems like TOPOLOGY_WORKER_METRICS and WORKER_METRICS provide the same
things.
(Comment is also same.)
Are semantics of two configurations different?
> Pluggable System Metrics
> ------------------------
>
> Key: STORM-862
> URL: https://issues.apache.org/jira/browse/STORM-862
> Project: Apache Storm
> Issue Type: New Feature
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
>
> I really wold be nice to have pluggable metrics for the __system bolt that
> would collect metrics for the entire JVM.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
