Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/589#discussion_r32522459
--- Diff: storm-core/src/jvm/backtype/storm/Config.java ---
@@ -1087,6 +1087,17 @@
public static final String TOPOLOGY_METRICS_CONSUMER_REGISTER =
"topology.metrics.consumer.register";
public static final Object TOPOLOGY_METRICS_CONSUMER_REGISTER_SCHEMA =
ConfigValidation.MapsValidator;
+ /**
+ * A map of metric name to class name implementing IMetric that will
be created once per worker JVM
+ */
+ public static final String TOPOLOGY_WORKER_METRICS =
"topology.worker.metrics";
+ public static final Object TOPOLOGY_WORKER_METRICS_SCHEMA = Map.class;
+
+ /**
--- End diff --
They do provide the same thing, but the intended audience is different.
Any config beginning with "topology." is intended for topology owners to set
where as worker.metrics is intended for a cluster owner to set. That way I can
force all topologies to collect a specific metric, but still allow end users to
easily add in more of their own metrics.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
