Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/539#issuecomment-112945204
@revans2
Far more better! Really amazing job, I appreciate it.
Btw, I have some points to ask / report.
- I excluded storm-kafka tests from Travis CI build (STORM-864), and github
diff shows that you revived storm-kafka.
I'd like to exclude it again, since tests in storm-kafka fails often, and
it leads that we can't believe Travis CI result. (Travis CI notifies us your PR
is broken but it's all about test failures of storm-kafka) Or do you have some
ideas to fix?
- drpc test report seems broken. There's some text between testcase tag.
https://travis-ci.org/apache/storm/jobs/67249769
```
175150 [main] INFO b.s.testing - Shutting down in process zookeeper
175159 [main] INFO b.s.testing - Done shutting down in process zookeeper
175160 [main] INFO b.s.testing - Deleting temporary path
/tmp/c4a2492e-6759-42c8-80bc-a48f42551e61
175161 [main] INFO b.s.testing - Deleting temporary path
/tmp/b9c776d0-5e9f-41b4-9f4e-dfd97669ae05
175161 [main] INFO b.s.testing - Deleting temporary path
/tmp/29bfa7dd-1a51-4561-8519-9a5355886ab6
175165 [main] INFO b.s.testing - Deleting temporary path
/tmp/1884de6c-49ae-4ca3-9b1f-0b7975420b56
</system-out>
</testcase>
175166 [Thread-851] INFO b.s.util - Async loop interrupted!
<testcase name="test-drpc-flow"
classname="backtype.storm.drpc-test">
<system-out>
175168 [main] INFO b.s.u.Utils - Using defaults.yaml from resources
175178 [main] INFO b.s.zookeeper - Starting inprocess zookeeper at port
2002 and dir /tmp/ebe0c08f-cf7b-47c6-9b24-123c16519c82
175181 [main] INFO b.s.u.Utils - Using defaults.yaml from resources
175190 [main] INFO b.s.d.nimbus - Starting Nimbus with conf
{"topology.builtin.metrics.bucket.size.secs" 60,
"nimbus.childopts" "-Xmx1024m",
"ui.filter.params" nil,
```
- If we can apply CDATA to report XML it would be more fine. Escaped
characters disturbs readability slightly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
