Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/storm/pull/572#discussion_r33065334
--- Diff: external/storm-kafka/src/test/storm/kafka/bolt/KafkaBoltTest.java
---
@@ -126,21 +124,30 @@ public void executeWithByteArrayKeyAndMessage() {
private KafkaBolt generateStringSerializerBolt() {
KafkaBolt bolt = new KafkaBolt();
Properties props = new Properties();
- props.put("metadata.broker.list",
broker.getBrokerConnectionString());
props.put("request.required.acks", "1");
props.put("serializer.class", "kafka.serializer.StringEncoder");
+ props.put("bootstrap.servers", broker.getBrokerConnectionString());
+ props.put("key.serializer",
"org.apache.kafka.common.serialization.StringSerializer");
+ props.put("value.serializer",
"org.apache.kafka.common.serialization.StringSerializer");
+ props.put("metadata.fetch.timeout.ms", 1000);
config.put(KafkaBolt.KAFKA_BROKER_PROPERTIES, props);
bolt.prepare(config, null, new OutputCollector(collector));
+ bolt.setAsync(false);
--- End diff --
do we have a test for async = true and the fireAndForget options?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
