[
https://issues.apache.org/jira/browse/STORM-871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14598399#comment-14598399
]
ASF GitHub Bot commented on STORM-871:
--------------------------------------
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/602
STORM-871 Change multilang heartbeat mechanism
* Introduce new way of treating heartbeat
** subprocess has to update pid file's modified time periodically
*** in default implementation we update pid file every 1 sec
** ShellSpout / ShellBolt checks pid file's modified time every 1 sec
** No more heartbeat tuple
It may introduces language constraints, so we need to gather opinions from
user/dev mailing list to make sure we can safely change mechanism.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-871
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/602.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #602
----
commit 13e63d25e1f5ce6f50b3a527b8a9bceaf9116660
Author: Jungtaek Lim <[email protected]>
Date: 2015-06-23T21:03:42Z
STORM-871 Change multilang heartbeat mechanism
* Introduce new way of treating heartbeat
** subprocess has to update pid file's modified time periodically
*** in default implementation we update pid file every 1 sec
** ShellSpout / ShellBolt checks pid file's modified time every 1 sec
** No more heartbeat tuple
----
> Change multilang heartbeat mechanism to multi-threading of subprocess
> ---------------------------------------------------------------------
>
> Key: STORM-871
> URL: https://issues.apache.org/jira/browse/STORM-871
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: Jungtaek Lim
>
> Having design constraint of multilang heartbeat, some issues are raised at
> the moment.
> (https://issues.apache.org/jira/browse/STORM-738 is a kind of reporting)
> I'm trying to add workarounds
> (https://issues.apache.org/jira/browse/STORM-742 and so on), but if we can
> get rid of design constraint it would be really great.
> Maybe we can use pid file of subprocess (subprocess write it from sendpid())
> to check subprocess heartbeat from ShellSpout / ShellBolt.
> Letting subprocess launch new thread which writes pid file periodically, to
> make sure "modified time" of file is periodically up to date. (It is just an
> idea, and it should be validated.)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
