Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/604#discussion_r33358774
--- Diff: storm-core/src/clj/backtype/storm/ui/core.clj ---
@@ -293,10 +293,17 @@
(bolt-comp-summs id))]
(sort-by #(-> ^ExecutorSummary % .get_executor_info .get_task_start)
ret)))
-(defn worker-log-link [host port topology-id]
+(defn worker-log-link [host port topology-id secure?]
(let [fname (logs-filename topology-id port)]
- (url-format (str "http://%s:%s/log?file=%s";)
- host (*STORM-CONF* LOGVIEWER-PORT) fname)))
+ (if secure?
--- End diff --
Actually I just had a thought. We probably want this to be
```
(if (and secure? (*STORM-CONF* LOGVIEWER-PORT))
...)
```
That way someone is not required to secure their logviewers if they secure
the main UI.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
