[
https://issues.apache.org/jira/browse/STORM-926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14614561#comment-14614561
]
ASF GitHub Bot commented on STORM-926:
--------------------------------------
GitHub user caofangkun opened a pull request:
https://github.com/apache/storm/pull/621
STORM-926:change pom to use maven-shade-plugin:2.2 and minimize the size of
shade jar and fix duplicated classes warnings of flue-examples
1: fix external/flux/flux-examples duplicated classes warings
```
[WARNING] commons-collections-3.2.1.jar, commons-beanutils-core-1.8.0.jar,
commons-beanutils-1.7.0.jar define 3 overlappping classes:
[WARNING] - org.apache.commons.collections.ArrayStack
[WARNING] - org.apache.commons.collections.BufferUnderflowException
[WARNING] - org.apache.commons.collections.Buffer
[WARNING] javax.servlet-3.1.jar, servlet-api-2.5-6.1.14.jar,
javax.servlet-api-3.0.1.jar, servlet-api-2.5.jar define 17 overlappping
classes:
[WARNING] - javax.servlet.ServletInputStream
[WARNING] - javax.servlet.Filter
[WARNING] - javax.servlet.http.HttpSession
[WARNING] - javax.servlet.FilterConfig
[WARNING] - javax.servlet.FilterChain
[WARNING] - javax.servlet.http.Cookie
[WARNING] - javax.servlet.http.HttpServletResponse
[WARNING] - javax.servlet.ServletConfig
[WARNING] - javax.servlet.RequestDispatcher
[WARNING] - javax.servlet.ServletRequest
[WARNING] - 7 more...
[WARNING] javax.servlet-3.1.jar, javax.servlet-api-3.0.1.jar define 26
overlappping classes:
[WARNING] - javax.servlet.Registration
[WARNING] - javax.servlet.DispatcherType
[WARNING] - javax.servlet.ServletRegistration$Dynamic
[WARNING] - javax.servlet.FilterRegistration
[WARNING] - javax.servlet.Registration$Dynamic
[WARNING] - javax.servlet.annotation.ServletSecurity$TransportGuarantee
[WARNING] - javax.servlet.FilterRegistration$Dynamic
[WARNING] - javax.servlet.descriptor.JspPropertyGroupDescriptor
[WARNING] - javax.servlet.annotation.ServletSecurity$EmptyRoleSemantic
[WARNING] - javax.servlet.descriptor.TaglibDescriptor
[WARNING] - 16 more...
[WARNING] hadoop-yarn-api-2.2.0.jar, hadoop-yarn-common-2.2.0.jar define 1
overlappping classes:
[WARNING] - org.apache.hadoop.yarn.util.package-info
[WARNING] maven-shade-plugin has detected that some .class files
[WARNING] are present in two or more JARs. When this happens, only
[WARNING] one single version of the class is copied in the uberjar.
[WARNING] Usually this is not harmful and you can skeep these
[WARNING] warnings, otherwise try to manually exclude artifacts
[WARNING] based on mvn dependency:tree -Ddetail=true and the above
[WARNING] output
```
2. minimized shade jars
For example:
mini flux-examples-0.11.0-SNAPSHOT.jar size from 52M to 12M
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/caofangkun/apache-storm storm-926
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/621.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #621
----
commit 18ca7966583902e2895949e01c8ea07457c44cb5
Author: caofangkun <[email protected]>
Date: 2015-07-06T05:14:18Z
STORM-926:change pom to use maven-shade-plugin:2.2 and minimize the size of
shade jar and fix duplicated classes warnings of flue-examples
----
> change pom to use maven-shade-plugin:2.2 and minimize the size of shade jar
> and fix duplicated classes warnings of flue-examples
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: STORM-926
> URL: https://issues.apache.org/jira/browse/STORM-926
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: caofangkun
> Assignee: caofangkun
> Priority: Minor
>
> For example:
> Before:
> {code}
> 51M
> /home/kuncao/workspace/storm/external/flux/flux-examples/target/flux-examples-0.11.0-SNAPSHOT.jar
> {code}
> After the patch :
> {code}
> diff --git a/external/flux/flux-examples/pom.xml
> b/external/flux/flux-examples/pom.xml
> index e3996e5..f102eaa 100644
> --- a/external/flux/flux-examples/pom.xml
> +++ b/external/flux/flux-examples/pom.xml
> @@ -79,9 +79,10 @@
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-shade-plugin</artifactId>
> - <version>1.4</version>
> + <version>1.6</version>
> <configuration>
>
> <createDependencyReducedPom>true</createDependencyReducedPom>
> + <minimizeJar>true</minimizeJar>
> </configuration>
> <executions>
> <execution>
> {code}
> The jar minimize to 12M
> {code}
> 12M
> /home/kuncao/workspace/storm/external/flux/flux-examples/target/flux-examples-0.11.0-SNAPSHOT.jar
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
