[
https://issues.apache.org/jira/browse/STORM-927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616767#comment-14616767
]
ASF GitHub Bot commented on STORM-927:
--------------------------------------
GitHub user DevInsanity opened a pull request:
https://github.com/apache/storm/pull/623
STORM-927: make storm jar wait for deployment to finish
This change makes the "storm jar" command on Windows wait for the topology
to deploy before exiting.
Tested with a flux-based topology.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DevInsanity/storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/623.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #623
----
commit cc15e07464d266d97038e832e7c7412a63961b9c
Author: DevInsanity <[email protected]>
Date: 2015-07-07T14:17:43Z
STORM-927: make storm jar wait for deployment to finish
----
> Storm.cmd on Windows shouldn't exit until deployment complete
> -------------------------------------------------------------
>
> Key: STORM-927
> URL: https://issues.apache.org/jira/browse/STORM-927
> Project: Apache Storm
> Issue Type: Improvement
> Affects Versions: 0.10.0
> Environment: Windows Server 2008 R2
> Reporter: Paul Milliken
> Priority: Minor
> Labels: windows
>
> The storm.cmd script returns before the topology has been deployed. This
> causes problems when attempting to automate deployments, as detecting
> failures is made difficult.
> It looks like this is because all storm command are ultimately invoked via
> "start /b" unless STORM_DEBUG is set. Attempting to workaround by setting
> STORM_DEBUG doesn't work, as the fix in STORM-322 hasn't been applied to the
> debug command.
> It looks like a relatively simple fix. Apply the STORM-322 fix to the debug
> route, and make the jar command use it by default.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
