Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/621#issuecomment-122013414
The changes look fine to me. I am a bit concerned about minimizing the
shaded jars. Have you tested this in a stand alone cluster? My understanding
is that it removes classes that don't appear to be included from the original
code, and with clojure I'm not 100% confident that everything is showing up
properly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
