Github user caofangkun commented on a diff in the pull request:
https://github.com/apache/storm/pull/639#discussion_r34865678
--- Diff: storm-core/src/clj/backtype/storm/daemon/worker.clj ---
@@ -288,7 +288,18 @@
(filter-key (complement (-> worker
:task-ids set))))
needed-connections (-> needed-assignment vals set)
needed-tasks (-> needed-assignment keys)
-
+
+ closed-connections (into [] (for [[node+port socket]
@(:cached-node+port->socket worker)]
+ (if (.isClosed socket)
node+port)))
--- End diff --
-1
We need take attention to unneeded connections but not closed connections ,
sometimes closed connections need to be reconnected by [retry
policy](https://github.com/apache/storm/blob/master/storm-core/src/jvm/backtype/storm/messaging/netty/Client.java#L138)
to make sure reconnect losted connections.
[refresh-connections](https://github.com/apache/storm/blob/master/storm-core/src/clj/backtype/storm/daemon/worker.clj#L313)
will try remove unneeded connections
by the way:
```
java.lang.IllegalArgumentException: No matching field found: isClosed for
class backtype.storm.messaging.netty.Client
```
May be you should use
[client.status()](https://github.com/apache/storm/blob/master/storm-core/src/jvm/backtype/storm/messaging/netty/Client.java#L191)
somewhere when you need .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
