Github user HeartSaVioR commented on the pull request:

    https://github.com/apache/storm/pull/642#issuecomment-122625519
  
    @vesense 
    Seems like your patch removes one invalid offset per each fill().
    
    We may apply same optimization here.
    When TopicOffsetOutOfRangeException occurs, we can remove invalid offsets 
from ExponentialBackoffMsgRetryManager at once.
    
    Though we should loop and examine each records to find them, it would be 
better than current.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to